Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download subdirectories #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tankevan
Copy link

@tankevan tankevan commented May 9, 2018

Changed 2 things here:

  1. Download All and Download Folder functionality changed to create subdirectories when downloading. I did this cos it's what I needed but I understand if keeping everything on thetop level is the intended behavior.

image

  1. Noticed that when downloading folders, tabActions are being downloaded as well, not sure how they got through your selectors but I made an edit in the eventPage.js file to pass when it detects an empty title.

I don't think the code is good to merge now, haven't tested point 1 extensively either. Just wanted to hear from you if you might be interested to implement either of these things. If you are, I'll clean up the code and make another PR.

@Yustynn
Copy link
Owner

Yustynn commented Jul 3, 2018

Sorry I missed this @tankevan. Yeah those things sound awesome. The subdirectories thing in particular is something I've wanted but haven't implemented.

If you're keen, absolutely go ahead with it. Just drop me a text if I miss your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants